-
Notifications
You must be signed in to change notification settings - Fork 36
[ECF GCP] Add documentation for tech preview #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vale Linting ResultsSummary: 14 suggestions found 💡 Suggestions (14)
|
🔍 Preview links for changed docs |
|
I am going to open this PR for review. There is one critical section still missing: the quick start. I can't write on it yet. You can see the tracking issue: https://elasticco.atlassian.net/browse/ENGPRD-1866. Every other section is ready to be reviewed. Maybe I will come back to add the |
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review pass. Very clever usage of the dropdowns!
Some comments/questions:
- What are the deployment methods for this? How is EDOT CF installed and removed?
- Depending on the above, what resources are created? Might be useful to have a list similar to this.
| deployment: | ||
| ess: preview | ||
| product: | ||
| edot_cf_gcp: preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This product doesn't exist yet but will be added in elastic/docs-builder#2303
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I had noticed
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
This is the missing |
|
@constanca-m Thanks! Let's follow up once the TF ReadMe is up, we might still want to wrap it in some pre- and post- steps. |
This PR is far from finished, I am only opening it to share the current status.
I have added the structure and some documentation. It still needs a few things that I have left commented in the document.